[#1299] Document T2.4b hybrid SQL helper pattern#1313
Conversation
Add weighted spend SQL helper section to airdrop-contracts.md explaining the hybrid implementation: TS wrapper for config injection + Postgres function as canonical SQL definition. Closes #1299 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The docs/airdrop-contracts.md addition accurately describes the T2.4b hybrid pattern. One acceptance item from #1299 is still missing: a clarifying comment on #1241.
Findings
-
[medium] Missing #1241 clarification comment required by #1299 acceptance.
- File:
docs/airdrop-contracts.md:47 - Suggestion: Post a comment on issue #1241 explaining that the actual implementation is hybrid:
weightedSpendQuery(config)injects TS config parameters whileweighted_spend(...)insupabase/migrations/00041_weighted_spend_function.sqlremains the canonical SQL function. Include a link to this PR or the docs section.
- File:
-
[low] CI is still pending for PR #1313.
- File:
.github/workflows/ci.yml - Suggestion: Let
lint-and-typecheckande2efinish green before merge.
- File:
Decision
Request changes. The docs change itself looks good, but the explicit #1241 comment acceptance item needs to be completed.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The docs accurately describe the T2.4b hybrid implementation: TS config injection through weightedSpendQuery(config) plus the canonical weighted_spend(...) DB function. The required #1241 clarification comment has also been posted.
Findings
- None.
Decision
Approve. CI is green for lint/typecheck and E2E on run 26455843197.
2 participants
Summary
Documents the actual T2.4b implementation in
docs/airdrop-contracts.md:weightedSpendQuery) for config injection + Postgres function (weighted_spend) as canonical SQLDoc-only change, no code modifications.
Closes #1299
🤖 Generated with Claude Code